Do not inline non-deterministic expressions as projection#16518
Merged
kasiafi merged 1 commit intotrinodb:masterfrom Mar 15, 2023
Merged
Do not inline non-deterministic expressions as projection#16518kasiafi merged 1 commit intotrinodb:masterfrom
kasiafi merged 1 commit intotrinodb:masterfrom
Conversation
losipiuk
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #16512
The incorrect result was caused by the Optimizer rule
ReplaceJoinOverConstantWithProject, which inlined a non-deterministic expression (in this case,uuid()), causing it to be evaluated separately for every row.Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X) Release notes are required, with the following suggested text: